Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-687

Make RemoteDriverTest thread-safe

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.5.0
    • avatica
    • None

    Description

      There is apparently a thread safety issue in RemoteDriverTest.testStatementLifecycle. Here is output from <a href="https://travis-ci.org/julianhyde/incubator-calcite/jobs/58869949">Travis</a>:

      ests run: 18, Failures: 1, Errors: 0, Skipped: 4, Time elapsed: 29.008 sec <<< FAILURE! - in org.apache.calcite.avatica.RemoteDriverTest
      testStatementLifecycle(org.apache.calcite.avatica.RemoteDriverTest)  Time elapsed: 1.807 sec  <<< FAILURE!
      java.lang.AssertionError: expected:<1> but was:<9>
      	at org.junit.Assert.fail(Assert.java:88)
      	at org.junit.Assert.failNotEquals(Assert.java:743)
      	at org.junit.Assert.assertEquals(Assert.java:118)
      	at org.junit.Assert.assertEquals(Assert.java:555)
      	at org.junit.Assert.assertEquals(Assert.java:542)
      	at org.apache.calcite.avatica.RemoteDriverTest.testStatementLifecycle(RemoteDriverTest.java:388)
      

      Presumably this occurs in Travis because several tests are running concurrently.

      I have disabled the test. We must fix this issue and re-enable the test.

      Attachments

        1. CALCITE-687.001.patch
          31 kB
          Josh Elser

        Issue Links

          Activity

            People

              elserj Josh Elser
              julianhyde Julian Hyde
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: