[CALCITE-6488] Ensure collations created by RelCollations are canonized once

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.37.0
• Fix Version/s: 1.38.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Ruben Q L
• Reporter: Ruben Q L
• Created: 20/Jul/24 08:44
• Updated: 17/Oct/24 22:41
• Resolved: 17/Oct/24 22:41

Description

RelCollations#of canonizes internally the result before returning it; however some callers unnecessarily re-canonize the result on their end.
RelCollations#shift does not canonize its result, some callers canonize on their end while others don't.

It is proposed to align their behaviour: RelCollations#of and RelCollations#shift will canonize internally their results before return, so that their callers do not need to do it on their end.

Issue Links

• links to: GitHub Pull Request #3874