Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-6148

Missing ASF header from some files in source distribution

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • avatica-1.24.0
    • None
    • avatica
    • None

    Description

      The ASF release policy requires all files (with few exception) in a distribution to have an ASF header.

      During the release of Apache Calcite Avatica 1.24.0 I noticed that some files in the source distribution do not contain an ASF header.

      grep -RiL "Licensed to the Apache Software Foundation (ASF)" | grep -v "LICENSE" | grep -v "NOTICE" | grep -v "README"
      
      core/src/main/resources/META-INF/services/java.sql.Driver
      .gitattributes
      metrics-dropwizardmetrics/src/main/resources/META-INF/services/org.apache.calcite.avatica.metrics.MetricsSystemFactory
      site/favicon.ico
      site/img/logo.png
      site/img/feather.png
      site/Gemfile.lock
      site/_layouts/external.html
      site/_layouts/docs.html
      site/_layouts/default.html
      site/_layouts/news_item.html
      site/_layouts/news.html
      site/_layouts/page.html
      site/_sass/_style.scss
      site/_sass/_pygments.scss
      site/_sass/_normalize.scss
      site/_sass/_gridism.scss
      site/_sass/_mixins.scss
      site/_sass/_font-awesome.scss
      site/css/screen.scss
      site/.gitignore
      site/_includes/news_contents_mobile.html
      site/_includes/footer.html
      site/_includes/docs_contents.html
      site/_includes/anchor_links.html
      site/_includes/docs_contents_mobile.html
      site/_includes/docs_ul.html
      site/_includes/section_nav.html
      site/_includes/primary-nav-items.html
      site/_includes/docs_option.html
      site/_includes/header.html
      site/_includes/news_contents.html
      site/_includes/top.html
      .ratignore
      noop-driver/src/main/resources/META-INF/services/java.sql.Driver
      .gitignore
      

      Most of the files listed above should not have an ASF header, and its normal that they don't but we may have to enrich the LICENSE file to clarify the licensing of some files such as .html in the site directory.

      Moreover for files under META-INF/services we can check if it is possible to add the ASF header.

      Attachments

        Activity

          People

            Unassigned Unassigned
            zabetak Stamatis Zampetakis
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: