[CALCITE-6102] SqlWriter in SqlInsert's unparse start a list but does not end it

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.35.0
• Fix Version/s: 1.37.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Mingcan Wang
• Reporter: Mingcan Wang
• Created: 10/Nov/23 09:51
• Updated: 06/May/24 22:19
• Resolved: 16/Nov/23 01:58

Description

SqlWriter in SqlInsert's unparse() start a list but does not end it.

There is a SparkSql :

with tmp as (select * from t1) insert into t2 select * from tmp 

I know calcite doesn't support parse "CTE + DML" for now.

But in some situation, I'll create a SqlNode like that.

SqlInsert sqlinsert;
SqlWith sqlWith;
// ....
sqlWith.setOperand(1, sqlInsert);
sqlWith.toString(); 

if we put a SqlInsert into a SqlWith's body manually, when we unparse the SqlWith , it will throw an Expception :

java.lang.IllegalArgumentException: Frame does not match current frame
 
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:122)
at org.apache.calcite.sql.pretty.SqlPrettyWriter.endList(SqlPrettyWriter.java:884)
at org.apache.calcite.sql.SqlWith$SqlWithOperator.unparse(SqlWith.java:109) 

 

Issue Links

• links to: GitHub Pull Request #3514