[CALCITE-5923] SqlOperatorTest using safeParameters are not using overridable fixture

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.35.0
• Fix Version/s: 1.36.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Runkang He
• Reporter: Runkang He
• Created: 13/Aug/23 09:48
• Updated: 10/Nov/23 11:34
• Resolved: 18/Oct/23 08:27

Description

There are some test cases in `SqlOperatorTest` directly use the `SqlOperatorFixtureImpl.DEFAULT` to get the `SqlOperatorFixture`, including `SqlOperatorTest.testCast` and many other test cases related with `CAST` operator. This causes that the result check is missing when execute `CalciteSqlOperatorTest`, which should has result check.

This violates the design principle introduced by CALCITE-4885, which we should alway use `SqlOperatorTest.fixture()` to get the `SqlOperatorFixture`. This principle allows us to override`fixture()` method in subclasses to run tests in a different environment.

So I think we should fix these related test cases to keep consistent with the principle.

Issue Links

• is related to: CALCITE-5678 Calcite should reject date literals not satisfying Gregorian calendar, per SQL standard
• relates to: CALCITE-5957 Valid DATE '1945-2-2' is not accepted due to regression
• relates to: CALCITE-5557 Add SAFE_CAST (BigQuery compatibility)
• relates to: CALCITE-6053 Upgrade Calcite to Avatica 1.24.0
• links to: GitHub Pull Request #3364