[CALCITE-5895] TABLESAMPLE(0) should return empty result

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.36.0
• Labels: pull-request-available
• Assignee: LakeShen
• Reporter: LakeShen
• Created: 04/Aug/23 07:47
• Updated: 10/Nov/23 11:34
• Resolved: 12/Aug/23 20:54

Description

For The sql:

select * from emp tablesample bernoulli(0) where empno > 5

The plan is :

LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2], MGR=[$3], HIREDATE=[$4], SAL=[$5], COMM=[$6], DEPTNO=[$7], SLACKER=[$8])
  LogicalFilter(condition=[>($0, 5)])
    LogicalTableScan(table=[[CATALOG, SALES, EMP]])

I think the correct result of above SQL is empty.

But its result is the following SQL result:

select * from emp where empno > 5

It's an incorrect result

Issue Links

• blocks: CALCITE-5906 JDBC adapter should generate TABLESAMPLE
• relates to: CALCITE-5916 In RelBuilder, add sample() method (equivalent to SQL TABLESAMPLE clause)
• relates to: CALCITE-5912 Add an implementation of TABLESAMPLE in Enumerable convention
• links to: GitHub Pull Request #3360

Sub-Tasks

• The result should be empty list when table sample rate is 0: Closed