[CALCITE-5727] RelOptFixture#checkUnchanged should assert planAfter is not present

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.34.0
• Fix Version/s: 1.35.0
• Component/s: tests
• Labels: pull-request-available
• Assignee: Benchao Li
• Reporter: Benchao Li
• Created: 27/May/23 03:31
• Updated: 27/Jul/23 10:22
• Resolved: 02/Jul/23 22:00

Description

This is discovered while I'm review another PR. And there are already some tests that using checkUnchanged, but the xml file still contains planAfter section, such as RelOptRulesTest#testNoReduceAverage.

IMO, there is no need to keep planAfter for checkUnchanged, and it does more harm than good to keep it. Even we can make planAfter the same with planBefore, it will bring burden for reading (because we'll identify the difference of planAfter and planBefore). And it will be more harmful when planAfter is different from planBefore.

Issue Links

• links to: GitHub Pull Request #3227