[CALCITE-5521] Remove redundant rowtype check in RelSubset#add - ASF JIRA

Voters

Watch issue

Watchers

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 1.34.0
Component/s: core
Labels:
- pull-request-available

Description

void add(RelNode rel) {
  if (set.rels.contains(rel)) {
    return;
  }

  VolcanoPlanner planner = (VolcanoPlanner) rel.getCluster().getPlanner();
  if (planner.getListener() != null) {
    RelOptListener.RelEquivalenceEvent event =
        new RelOptListener.RelEquivalenceEvent(
            planner,
            rel,
            this,
            true);
    planner.getListener().relEquivalenceFound(event);
  }

  // If this isn't the first rel in the set, it must have compatible
  // row type.
  if (set.rel != null) {
    RelOptUtil.equal("rowtype of new rel", rel.getRowType(),
        "rowtype of set", getRowType(), Litmus.THROW);
  }
  set.addInternal(rel);
  if (false) {
    Set<CorrelationId> variablesSet = RelOptUtil.getVariablesSet(rel);
    Set<CorrelationId> variablesStopped = rel.getVariablesSet();
    Set<CorrelationId> variablesPropagated =
        Util.minus(variablesSet, variablesStopped);
    assert set.variablesPropagated.containsAll(variablesPropagated);
    Set<CorrelationId> variablesUsed = RelOptUtil.getVariablesUsed(rel);
    assert set.variablesUsed.containsAll(variablesUsed);
  }
}