Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-5222

Support more EXTRACT field values (or allow arbitrary in parse?)

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Duplicate
    • None
    • 1.32.0
    • None
    • None

    Description

      E.g. a number of BigQuery EXTRACTs from https://cloud.google.com/bigquery/docs/reference/standard-sql/timestamp_functions#extract do not parse with the babel parser

      EXTRACT(DAYOFWEEK FROM <date_col>)
      EXTRACT(TIME FROM <date_col>)

      (also DATE, DATETIME, DAYOFYEAR... there may be others)

      Other dialects may have similar problems, e.g. "EXTRACT(JULIAN...)" in Postgres looks like it wouldn't parse either.

      Calcite chasing down every value ever implemented by a DB vendor here seems like it might be too tall of a task, but perhaps allowing for an arbitrary keyword in that syntactic position, and then users of the parser would have to handle it if the parse of the EXTRACT comes out with an arbitrary symbol, rather than a TimeUnit enum value for one of the known EXTRACT fields.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              swtalbot Steven Talbot
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: