[CALCITE-506] Update EnumerableRelImplementor.stash so it is suitable for all kinds of classes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0-incubating
• Fix Version/s: 1.0.0-incubating
• Labels: newbie
• Assignee: Julian Hyde
• Reporter: Vladimir Sitnikov
• Created: 02/Dec/14 11:48
• Updated: 08/Feb/15 08:56
• Resolved: 13/Dec/14 11:27

Description

  public Expression stash(RelNode child, Class clazz) {
    final ParameterExpression x = register(child, clazz);
    final Expression e = Expressions.call(getRootExpression(),
        BuiltInMethod.DATA_CONTEXT_GET.method, Expressions.constant(x.name));
    return Expressions.convert_(e, clazz);
  }

I would like to make two corrections here:
1) I think public <T> Expression st(T x, Class<? super T> clazz) { should be better signature.
2) It makes sense to translate DATA_CONTEXT_GET as a store to a final local variable at the very start of public org.apache.calcite.linq4j.Enumerable bind(final org.apache.calcite.DataContext root0) method (see implementRoot), so at the usage time it is just a load of local variable, not a map.get

Issue Links

• relates to: CALCITE-529 Allow to pass java object via rexBuilder.makeLiteral()