[CALCITE-4987] JDBC adapter generates incorrect query when ORDER BY alias collides with field in SELECT ITEM

• Type: Bug
• Status: In Progress
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.29.0
• Component/s: core
• Labels: pull-request-available

Environment

jdk8

• Assignee: yanjing.wang
• Reporter: yanjing.wang
• Due: 25/Jan/22
• Created: 14/Jan/22 09:47
• Updated: 28/Jun/23 19:26

Description

I reproduce with the following query.

 

SELECT sum(shelf_width) as shelf_width FROM product ORDER BY shelf_width

you must have noticed that the shelf_width alias is same with field 'shelf_width' in sum.

I expected the query hasn't changed when I test in RelToSqlConverterTest. But I get unexpected query is 

SELECT sum(shelf_width) as shelf_width FROM product ORDER BY sum(shelf_width)  

 the unexpected query is not valid in the dialect which support order by alias conformance.

 

Issue Links

• Blocked: CALCITE-2552 JDBC adapter generates Non-Dialect Specific Order By Field Identifier
• Blocked: CALCITE-3440 RelToSqlConverter does not properly alias ambiguous ORDER BY
• is related to: CALCITE-5724 Generated SQL uses literal values in ORDER BY clauses
• is related to: CALCITE-5775 Null direction emulation broken for complex expressions on some dialects
• is related to: CALCITE-2552 JDBC adapter generates Non-Dialect Specific Order By Field Identifier
• links to: GitHub Pull Request #2693