[CALCITE-4986] Make HepProgram thread-safe

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.30.0
• Labels: pull-request-available
• Assignee: Julian Hyde
• Reporter: Julian Hyde
• Created: 13/Jan/22 00:11
• Updated: 19/Mar/22 09:17
• Resolved: 19/Jan/22 06:23

Description

HepProgram uses mutable fields for its working state and is therefore not thread-safe. If two threads are planning queries simultaneously and are using the same HepProgram instances they might conflict with each other. I suspect that this happens several times in Calcite's standard set of rules.

This change would move the mutable state out of HepProgram, so that HepProgram is fully immutable and therefore thread-safe.

It would also modernize some of the internals; for instance, class HepInstruction.MatchLimit has a field int limit that could be made final and assigned in the constructor.

Issue Links

• links to: GitHub Pull Request #2691