[CALCITE-4963] Extensibility of SqlDialectFactory lacks reusability of SqlDialectFactoryImpl.*

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.30.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Marco Jorge
• Created: 23/Dec/21 17:40
• Updated: 19/Mar/22 09:19
• Resolved: 03/Jan/22 22:12

Description

(nicetities first - great project and thanks all for the great work)

Although it's possible to extend the SqlDialectFactory, the custom implementation cannot reuse any of the behaviour of the default SqlDialectFactoryImpl. The default SqlDialectFactoryImpl has lots of important/reusable behaviour such as #getCasing, #isCaseSensitive, #getNullCollation or even the default decisioning in the #create method.

If any user needs to provide a custom SqlDialect yet still support the existing SqlDialects the user needs to copy the whole SqlDialectFactoryImpl to make the custom changes.

This request is to make the default behavior in SqlDialectFactoryImpl reusable so that extensions don't need to fork a whole class.

Issue Links

• links to: GitHub Pull Request #2658