[CALCITE-4932] Deprecate JdbcCalc and remove JdbcCalcRule

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.28.0
• Fix Version/s: 1.29.0
• Component/s: jdbc-adapter
• Labels: pull-request-available
• Assignee: Francesco Gini
• Reporter: Francesco Gini
• Created: 11/Dec/21 16:59
• Updated: 04/Jan/22 08:27
• Resolved: 04/Jan/22 08:27

Description

The jdbc adapter includes a node and rule for Calc ( JdbcCalc a JdbcCalcRule ). Calc is an operation that is introduced only later in the planner to optimise certain code generation and it is not needed for the jdbc adapter.

As it stands the rule JdbcCalcRule is never triggered because the Jdbc convention rules are applied before the Calc node is introduced in the plan. However, if a user try to use a custom rule set they might end up with a JdbcCalc which introduces problems like the one described in https://issues.apache.org/jira/browse/CALCITE-4905 .

Because JdbcCalc is not an optimisation needed for jdbc anyway we should deprecate JdbcCalc and its respective rule JdbcCalcRule. The rule should also be removed from JdbcRules.rules

See ticket https://issues.apache.org/jira/browse/CALCITE-4905  for a discussion around deprecating JdbcCalc

Issue Links

• supercedes: CALCITE-4905 JdbcCalc does not extend Calc
• links to: GitHub Pull Request #2642
• links to: pull request