[CALCITE-4925] AggregateReduceFunctionsRule should accept arbitrary predicates

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.29.0
• Labels: pull-request-available
• Assignee: Will Noble
• Reporter: Will Noble
• Created: 08/Dec/21 00:17
• Updated: 04/Jan/22 08:27
• Resolved: 04/Jan/22 08:27

Description

AggregateReduceFunctionsRule allows you to specify which functions to reduce, but only allows you to specify by function type. For instance, you can either reduce all SUM functions, or no SUM functions, but not a subset of SUM functions (say, only the SUM functions with distinct keys). Allowing the user to specify an arbitrary predicate would allow us to selectively apply the rule to functions without distinct keys, which matters in Looker due to the fact that distinct keys cause an aggregate to be impossible to roll up, and when that's the case, we'd like to avoid reducing the functions for the purpose of aggregate awareness.

Issue Links

• links to: GitHub Pull Request #2634