Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-4766

Remove unreachable code from SqlValidatorImpl#performUnconditionalRewrites for VALUES node

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.28.0
    • None

    Description

      in SqlValidatorImpl line 1387, there is a line `if (underFrom || true)`:

      The condition is always true and I think we can remove this condition.

      Attachments

        1. image-2021-09-08-15-46-09-395.png
          162 kB
          Jianhui Dong

        Issue Links

          links to

          Web Link GitHub Pull Request #2511

          Activity

            People

              Unassigned Unassigned
              lam167 Jianhui Dong
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m