[CALCITE-4740] JDBC adapter generates incorrect HAVING clause in BigQuery dialect

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.27.0
• Fix Version/s: 1.28.0
• Component/s: core
• Labels: pull-request-available

Environment

jdk8

macos

• Assignee: Unassigned
• Reporter: yanjing.wang
• Created: 17/Aug/21 07:28
• Updated: 20/Oct/21 05:24
• Resolved: 13/Oct/21 23:25

Description

I'm converting 

String query = select
 "product_id" ,  sum("shelf_width")
from "foodmart"."product"
where "product_id" > 0
group by "product_id" having sum("shelf_width") > 1

with big query dialect, but results

SELECT product_id, SUM(shelf_width)
FROM foodmart.product
WHERE product_id > 0
GROUP BY product_id
HAVING `EXPR$1` > 1

Maybe we need replace having clause aliases when stripping trivial aliases.

Issue Links

• is related to: CALCITE-3936 RelToSqlConverter changes target of ambiguous HAVING clause with a Project on Filter on Aggregate
• links to: GitHub Pull Request #2494
• links to: GitHub Pull Request #2504