[CALCITE-4650] TopDownRuleDriver.DeriveTrait.derive produces wrong AssertionError when registering new nodes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Cannot Reproduce
• Affects Version/s: 1.27.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Vladimir Ozerov
• Reporter: Vladimir Ozerov
• Created: 13/Jun/21 18:31
• Updated: 21/Jul/21 04:48
• Resolved: 21/Jul/21 04:48

Description

TopDownRuleDriver.DeriveTrait.derive asserts that a derived node belongs to the same RelSet as the original node.

If the original node N1 refers to set S1, the derived node N2 might be registered in the set S2, if S1 was merged to S2 between the registration of N1 and derivation of N2.

Currently, we compare the original set of the original node N1 with the canonical set of the derived node N2. This leads to false assertions.

Dicussion:
https://lists.apache.org/thread.html/rd26b7a0f55906cebf5abcaf349ab2bec414e164fa4d9f63789bf34c8%40%3Cdev.calcite.apache.org%3E

Issue Links

• links to: GitHub Pull Request #2438