Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-465

Remove OneRow and Empty relational expressions; Values will suffice

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      The OneRow and Empty relational expressions do not give any descriptive power over a Values relational expression with 1 tuple and 0 tuples, respectively. We should remove them (and their sub-classes).

      Now that RelOptRuleOperand can take a Predicate, it is easy to write rules that match a Values that has zero tuples.

      Benefits include efficiency (the planning process will creature fewer relational expressions) and rule re-use (rules applicable to Values are now automatically applicable to 1- and 0-row relational expressions).

        Activity

        Hide
        julianhyde Julian Hyde added a comment -

        Closing now that 1.0.0-incubating has been released.

        Show
        julianhyde Julian Hyde added a comment - Closing now that 1.0.0-incubating has been released.
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/71dd68de .

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            julianhyde Julian Hyde
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development