Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-445

Pull up filters rejected by a ProjectableFilterableTable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Suppose that t (i, j, k) is a table that implements ProjectableFilterableTable, we execute the query select k from t where j = 1, and t refuses to evaluate the filter j = 1.

      We should still push the project to the table. But we need to project the extra column, j needed by the filter, and transform it, because it now occurs after the project.

        Issue Links

          Activity

          Hide
          julianhyde Julian Hyde added a comment -

          As part of my fix for CALCITE-558, I am changing Calcite to not push any filters or projects if any filters are rejected. This is safe (never produces the wrong results) but not very efficient.

          As part of this this issue we should remedy this. I think the solution may be to have the interpreter apply some existing rules (e.g. FilterProjectTransposeRule) in the "rewrite" phase. Maybe we can obsolete the rewrite method altogether.

          Show
          julianhyde Julian Hyde added a comment - As part of my fix for CALCITE-558 , I am changing Calcite to not push any filters or projects if any filters are rejected. This is safe (never produces the wrong results) but not very efficient. As part of this this issue we should remedy this. I think the solution may be to have the interpreter apply some existing rules (e.g. FilterProjectTransposeRule) in the "rewrite" phase. Maybe we can obsolete the rewrite method altogether.
          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/bd0b6061 .
          Hide
          julianhyde Julian Hyde added a comment -

          Closing now that 1.1.0-incubating has been released.

          Show
          julianhyde Julian Hyde added a comment - Closing now that 1.1.0-incubating has been released.

            People

            • Assignee:
              julianhyde Julian Hyde
              Reporter:
              julianhyde Julian Hyde
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development