Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-4425

Class DefaultEdge lacks a proper toString implementation

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.27.0
    • core

    Description

      It is convenient to build a graph as an object of DefaultDirectedGraph. The class has a good toString implementation, which greatly helps examining the structure of the graph.
      However, the output of the method may be confusing. In our system, the toString method produces the following result:

      graph(vertices: [0, 1, 2, 3, 4, 5, 6], edges: [org.apache.calcite.util.graph.DefaultEdge@1a550334, org.apache.calcite.util.graph.DefaultEdge@891ce8a1, org.apache.calcite.util.graph.DefaultEdge@ba5c5190, org.apache.calcite.util.graph.DefaultEdge@c894f6b3, org.apache.calcite.util.graph.DefaultEdge@d72993fe, org.apache.calcite.util.graph.DefaultEdge@da030cc4, org.apache.calcite.util.graph.DefaultEdge@de17986f, org.apache.calcite.util.graph.DefaultEdge@e20be355, org.apache.calcite.util.graph.DefaultEdge@ef7b8a83, org.apache.calcite.util.graph.DefaultEdge@f2b672ef, org.apache.calcite.util.graph.DefaultEdge@f547e446])

      The reason is that the default edge type is DefaultEdge, and the DefaultEdge class does not have a proper toString implementation. So we want to provide one, so that it helps investigating the internals of the graph.

      Attachments

        Issue Links

          Activity

            People

              fan_li_ya Liya Fan
              fan_li_ya Liya Fan
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h