Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-4422

Add MethodCanBeStatic check via ErrorProne

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.26.0
    • Fix Version/s: 1.27.0
    • Component/s: None

      Description

      See https://errorprone.info/bugpattern/MethodCanBeStatic

      A private method that does not reference the enclosing instance can be static

      Note: the key driver is code readability. If a method is static, it is clear that it can't access instance fields, and all it can access is provided via arguments.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                vladimirsitnikov Vladimir Sitnikov
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m