[CALCITE-4422] Add MethodCanBeStatic check via ErrorProne

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.26.0
• Fix Version/s: 1.27.0
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Vladimir Sitnikov
• Created: 30/Nov/20 08:59
• Updated: 03/Jun/21 22:32
• Resolved: 08/Dec/20 09:12

Description

See https://errorprone.info/bugpattern/MethodCanBeStatic

A private method that does not reference the enclosing instance can be static

Note: the key driver is code readability. If a method is static, it is clear that it can't access instance fields, and all it can access is provided via arguments.

Issue Links

• links to: GitHub Pull Request #2285