Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-4199 Add nullability annotations to the methods and fields, ensure consistency with checkerframework
  3. CALCITE-4236

Clarify if nulls are permissible to return from .SqlOperator#inferReturnType

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 1.25.0
    • None
    • core
    • None

    Description

      1) Javadoc for SqlOperator#inferReturnType does not say if nulls are allowed
      2) The default implementation throws exception if returnTypeInference is missing, and it throws exception in case returnTypeInference.inferReturnType(opBinding) returns null.
      3) Some of the operators can return null. For instance, SqlMultisetQueryConstructor has if (...) return null (which might happen to be never executed)

      It looks like we need to add "never null" tp the javadoc of SqlOperator#inferReturnType

      Attachments

        Activity

          People

            Unassigned Unassigned
            vladimirsitnikov Vladimir Sitnikov
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: