Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-4203

RelMdUniqueKeys should not return empty when meeting Intersect and Minus if its input has unique keys

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.26.0
    • Component/s: None

      Description

      Currently, we get an empty unique key for Intersect and Minus if its all is true. 

       

      // code placeholder
      public Set<ImmutableBitSet> getUniqueKeys(SetOp rel, RelMetadataQuery mq,
          boolean ignoreNulls) {
        if (!rel.all) {
          return ImmutableSet.of(
              ImmutableBitSet.range(rel.getRowType().getFieldCount()));
        }
        return ImmutableSet.of();
      }
      

      However, from the semantic of Intersect and Minus, we can get their unique keys from its input even if its all is true. 

        Attachments

          Activity

            People

            • Assignee:
              Chunwei Lei Chunwei Lei
              Reporter:
              Chunwei Lei Chunwei Lei

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 40m
                40m

                  Issue deployment