Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-4170

Improve simplification of "<>" predicates

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.26.0
    • Component/s: None
    • Labels:
      None

      Description

      Improve simplification of "<>" (not equals) predicates. The goal is to simplify "a <> 1 or a = 1" to "true".

      Today we can simplify "a = 1 or a <> 1" to "true" (the same expression with the terms re-ordered) but we cannot simplify "a <> 1 or a = 1" to "true". The problem is this. The algorithm for simplifying "or" builds a up a list of predicates as it works left to right. After dealing with "a = 1" RexSimplifier has a predicate "a = 1" and therefore it can simplify the next predicate to anything that returns the right result over the possible inputs - which will not include a = 1 - and therefore 'a <> 1' can be simplified to 'true'.

      But today, we can't take that approach with "a <> 1 or a = 1" because "a <> 1" cannot be represented as a single range. It needs two ranges - less than 1 or greater than 1. The fix is therefore to allow predicates to be range sets not just ranges.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                julianhyde Julian Hyde
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: