[CALCITE-4158] In generated SQL, "*" should be followed by space

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.23.0
• Fix Version/s: 1.28.0
• Component/s: core
• Labels: pull-request-available
• Assignee: xiong duan
• Reporter: Roman Churganov
• Created: 05/Aug/20 20:09
• Updated: 20/Oct/21 05:25
• Resolved: 21/Jun/21 19:38

Description

Printing a query with the following parameters  gives a result

SELECT *FROM TAB

Note: no space between "*" and "FROM".

val parser = SqlParser.create("",
  SqlParser.configBuilder()
    .setCaseSensitive(false)
   .setParserFactory(SqlParserImpl.FACTORY)
   .setQuoting(Quoting.DOUBLE_QUOTE)
    .build())

val query = parser.parseQuery("select * from tab")
val actual = query.toSqlString { c: SqlWriterConfig ->
    c.withDialect(PostgresqlSqlDialect.DEFAULT)
      .withAlwaysUseParentheses(false)
      .withSelectListItemsOnSeparateLines(false)
      .withCaseClausesOnNewLines(false)
      .withQuoteAllIdentifiers(false)
      .withIndentation(0)
      .withClauseStartsLine(false)
      .withFromFolding(SqlWriterConfig.LineFolding.WIDE)
      .withSelectFolding(SqlWriterConfig.LineFolding.WIDE)
      .withLineFolding(SqlWriterConfig.LineFolding.WIDE)
   }.sql
println(actual)

Issue Links

• links to: GitHub Pull Request #2442