[CALCITE-4120] Inconsistent Calendar used In JdbcMeta between prepareAndExecute and Fetch

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Chris Snowden
• Created: 14/Jul/20 15:53
• Updated: 03/Mar/23 01:47

Description

org.apache.calcite.avatica.jdbc.JdbcMeta prepareAndExecute is using UTC calendar but fetch is using local calendar, results in inconsistent TZs being applied for single statement. 

https://github.com/apache/calcite-avatica/blob/master/server/src/main/java/org/apache/calcite/avatica/jdbc/JdbcMeta.java

https://github.com/apache/calcite-avatica/blob/master/server/src/main/java/org/apache/calcite/avatica/jdbc/JdbcResultSet.java

 

org.apache.calcite.avatica.jdbc.JdbcMeta 

final Calendar calendar = Unsafe.localCalendar(); //LOCAL

public ExecuteResult prepareAndExecute(
    StatementHandle h, 
    String sql, 
    long maxRowCount, 
    int maxRowsInFirstFrame, 
    PrepareCallback callback) throws NoSuchStatementException {
....
    resultSets.add(JdbcResultSet.create(h.connectionId, h.id, info.getResultSet(), maxRowsInFirstFrame)); //USES UTC CALENDAR      
....
}

public Frame fetch(
    StatementHandle h, 
    long offset, 
    int fetchMaxRowCount) throws NoSuchStatementException, MissingResultsException {
...
    return JdbcResultSet.frame(statementInfo, statementInfo.getResultSet(), offset, fetchMaxRowCount, calendar, Optional.<Meta.Signature>absent()); //USES LOCAL CALENDAR
...
}

____________________________________________________________________


org.apache.calcite.avatica.jdbc.JdbcResultSet

public static JdbcResultSet create(
    String connectionId, 
    int statementId,      
    ResultSet resultSet, 
    int maxRowCount, 
    Meta.Signature signature) {

    final Calendar calendar = DateTimeUtils.calendar(); //UTC
    ....
    final Meta.Frame firstFrame = frame(null, resultSet, 0, fetchRowCount, calendar, Optional.of(signature))
    ....
}

Issue Links

• duplicates: CALCITE-5552 Returned timestamp is incorrect after the 100th row