[CALCITE-4038] Refactor RexVisitor, RexBiVisitor, RelOptUtil.InputFinder

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.24.0
• Assignee: Julian Hyde
• Reporter: Julian Hyde
• Created: 02/Jun/20 21:56
• Updated: 25/Jul/20 14:59
• Resolved: 11/Jun/20 20:05

Description

Various improvements to RexVisitor, RexBiVisitor, RelOptUtil.InputFinder  classes.

1. Make mutable field RelOptUtil.InputFinder.inputBitSet private. The field still exists, public and deprecated, but it shadows a new private field. Rather than calling InputFinder.inputBitSet.build() you should now call InputFinder.build().

2. In RexVisitor and RexBiVisitor add methods visitList and visitEach (the former returns a list, and the latter returns void).

3. Deprecate RexShuttle.apply in favor of visitList.

4. Add RexWindowBound.accept(RexBiVisitor).

5. For RexBiVisitor<X, Integer> add a method visitEachIndexed, the index passed as the 'payload' argument.

6. Add abstract implementations of RexBiVisitor: RexUnaryBiVisitor and RexBiVisitorImpl.