[CALCITE-3985] Simplify grouped window function in parser

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.24.0
• Assignee: Rui Wang
• Reporter: Rui Wang
• Created: 09/May/20 18:43
• Updated: 25/Jul/20 14:59
• Resolved: 24/May/20 20:09

Description

Currently in parser, there is [1]:

SqlCall GroupByWindowingCall():
{
    final Span s;
    final List<SqlNode> args;
    final SqlOperator op;
}
{
    (
        <TUMBLE>
        {
            s = span();
            op = SqlStdOperatorTable.TUMBLE_OLD;
        }
    |
        <HOP>
        {
            s = span();
            op = SqlStdOperatorTable.HOP_OLD;
        }
    |
        <SESSION>
        {
            s = span();
            op = SqlStdOperatorTable.SESSION_OLD;
        }
    )
    args = UnquantifiedFunctionParameterList(ExprContext.ACCEPT_SUB_QUERY) {
        return op.createCall(s.end(this), args);
    }
}

The s=span() are duplicates and there could be a way to keep only one s=span().

[1]: https://github.com/apache/calcite/blob/master/core/src/main/codegen/templates/Parser.jj#L6049

Issue Links

• links to: Github Pull Request #1974