Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.24.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently in parser, there is [1]:

      SqlCall GroupByWindowingCall():
      {
          final Span s;
          final List<SqlNode> args;
          final SqlOperator op;
      }
      {
          (
              <TUMBLE>
              {
                  s = span();
                  op = SqlStdOperatorTable.TUMBLE_OLD;
              }
          |
              <HOP>
              {
                  s = span();
                  op = SqlStdOperatorTable.HOP_OLD;
              }
          |
              <SESSION>
              {
                  s = span();
                  op = SqlStdOperatorTable.SESSION_OLD;
              }
          )
          args = UnquantifiedFunctionParameterList(ExprContext.ACCEPT_SUB_QUERY) {
              return op.createCall(s.end(this), args);
          }
      }
      

      The s=span() are duplicates and there could be a way to keep only one s=span().

      [1]: https://github.com/apache/calcite/blob/master/core/src/main/codegen/templates/Parser.jj#L6049

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                amaliujia Rui Wang
                Reporter:
                amaliujia Rui Wang
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h
                  1h