[CALCITE-3723] Following the change to add hints to RelNode, deprecate the old constructors

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.22.0
• Labels: pull-request-available
• Assignee: Danny Chen
• Reporter: Julian Hyde
• Created: 10/Jan/20 19:34
• Updated: 06/Mar/20 04:33
• Resolved: 13/Jan/20 04:32

Description

In CALCITE-482 and CALCITE-3590 we added constructors for various sub-classes RelNode (LogicalProject, LogicalAggregate, and others) that take a list of hints. But now those classes have two constructors. Our practice has been to have only one (public, non-deprecated) constructor in each RelNode class. (Otherwise we would have dozens.) So, please deprecate the old constructors and change code that uses them.

Can we do this before 1.22?

Also note that the new and old constructors have exactly the same comment. You should avoid that. But in this case, just remove the comment of the deprecated constructor.

The non-hints constructor does new ArrayList<>(). Please change to use ImmutableList.of(), which saves a malloc.

cc danny0405 and icshuo.

Issue Links

• links to: GitHub Pull Request #1752