[CALCITE-3595] Test infrastructure overwrites reference log with wrong results

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.22.0
• Component/s: build
• Labels: pull-request-available
• Assignee: Danny Chen
• Reporter: Julian Hyde
• Created: 12/Dec/19 00:46
• Updated: 06/Mar/20 04:33
• Resolved: 20/Dec/19 03:21

Description

When I add a test case to a test that is based on DiffRepository (such as SqlPrettyWriterTest), and run it in Intellij, the first time gives an error because the actual output does not match the expected output. This is good.

I would expect that if I run it again, it will fail again, but it does not. I'm not sure exactly what is going on, but maybe the test is reading from an output file instead of a reference log. This was probably broken during the migration to gradle, because the paths for reference logs have all changed.

This bug prevents me from using the workflow where I add a test case, run it, and when it fails, change the code until the output looks right, then overwrite the reference log.

Issue Links

• links to: GitHub Pull Request #1671