[CALCITE-3388] StackOverflowError for creating structured RelDataType from class type

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Cannot Reproduce
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Wang Yanlin
• Created: 05/Oct/19 02:33
• Updated: 14/Oct/19 07:07
• Resolved: 14/Oct/19 07:06

Description

When creating a structured RelDataType from a java type with recursion reference,

StackOverflowError occurs, full stack trace
 

java.lang.StackOverflowError
	at java.lang.Class.privateGetPublicFields(Class.java:2600)
	at java.lang.Class.getFields(Class.java:1557)
	at org.apache.calcite.rel.type.RelDataTypeFactoryImpl.fieldsOf(RelDataTypeFactoryImpl.java:440)
	at org.apache.calcite.rel.type.RelDataTypeFactoryImpl.access$700(RelDataTypeFactoryImpl.java:50)
	at org.apache.calcite.rel.type.RelDataTypeFactoryImpl$JavaType.<init>(RelDataTypeFactoryImpl.java:568)
	at org.apache.calcite.rel.type.RelDataTypeFactoryImpl$JavaType.<init>(RelDataTypeFactoryImpl.java:560)
	at org.apache.calcite.rel.type.RelDataTypeFactoryImpl$JavaType.<init>(RelDataTypeFactoryImpl.java:554)
	at org.apache.calcite.rel.type.RelDataTypeFactoryImpl.createJavaType(RelDataTypeFactoryImpl.java:120)
	at org.apache.calcite.jdbc.JavaTypeFactoryImpl.createType(JavaTypeFactoryImpl.java:143)
	at org.apache.calcite.jdbc.JavaTypeFactoryImpl.createStructType(JavaTypeFactoryImpl.java:82)
	at org.apache.calcite.jdbc.JavaTypeFactoryImpl.createType(JavaTypeFactoryImpl.java:158)
	at org.apache.calcite.jdbc.JavaTypeFactoryImpl.createStructType(JavaTypeFactoryImpl.java:82)
	at org.apache.calcite.jdbc.JavaTypeFactoryImpl.createType(JavaTypeFactoryImpl.java:158)
	at org.apache.calcite.jdbc.JavaTypeFactoryImpl.createStructType(JavaTypeFactoryImpl.java:82)
	at org.apache.calcite.jdbc.JavaTypeFactoryImpl.createType(JavaTypeFactoryImpl.java:158)
	at org.apache.calcite.jdbc.JavaTypeFactoryImpl.createStructType(JavaTypeFactoryImpl.java:82)

Add the test case in JavaTypeFactoryTest to reproduce the exception

 /***/
  private static class  RecursionStruct {
    public Integer intField;
    public RecursionStruct next;
  }

  /***/
  private static class  RecursionStruct1 {
    public Integer intField;
    public RecursionStruct2 struct2;
  }

  /***/
  private static class  RecursionStruct2 {
    public Integer intField;
    public RecursionStruct1 struct1;
  }

@Test public void testRecursion() {
      TYPE_FACTORY.createStructType(RecursionStruct.class);
      TYPE_FACTORY.createStructType(RecursionStruct1.class);
  }

 

Better to check for recursion and throw an exception explicitly.

Issue Links

• links to: GitHub Pull Request #1486