[CALCITE-3183] Trimming method for Filter rel uses wrong traitSet

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.21.0
• Labels: pull-request-available
• Assignee: Juhwan Kim
• Reporter: Juhwan Kim
• Created: 08/Jul/19 22:04
• Updated: 10/Sep/19 21:36
• Resolved: 15/Jul/19 17:50

Description

It seems like there is a bug here: https://github.com/apache/calcite/blob/e8d598a434e8dbadaf756f8c57c748f4d7e16fdf/core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java#L487.

Unlike other trimming methods, filter trim function copies the current filter rel and directly pushes it to the builder instead of calling factory method for filter rel. The problem with the current code is that it uses the same traitSet even though it would no longer be valid after trimming its input. For example, fields in collation might have been updated after trimming. We should reflect this change when creating a new rel.

 

Issue Links

• links to: GitHub Pull Request #1309