Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-3034

CSV test case description does not match it's code logic

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      The javadoc of the o.a.c.t.CsvTest#testFilterableWhere2 is 'Filter that can be partly handled by CsvFilterableTable.'
      Actually it never handle it, o.a.c.a.c.CsvFilterableTable#scan will get the whole WHERE condition RexNode and that's SqlKind is AND.
      So, the code logic will return false directly.

      Attachments

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            danny0405 Danny Chen
            Faxian FaxianZhao
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 2h
                2h

                Slack

                  Issue deployment