[CALCITE-3014] SqlConformanceEnum is hard coded in a few places

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.19.0
• Component/s: core
• Assignee: Unassigned
• Reporter: Lai Zhou
• Created: 22/Apr/19 08:53
• Updated: 28/Apr/19 07:31

Description

I found SqlConformanceEnum is hard coded in a few places.

https://github.com/apache/calcite/blob/ee83efd360793ef4201f4cdfc2af8d837b76ca69/core/src/main/java/org/apache/calcite/rex/RexExecutorImpl.java#L81

https://github.com/apache/calcite/blob/72f36a8830afe7f903d8cb32cf547ea484e49fef/core/src/main/java/org/apache/calcite/interpreter/AggregateNode.java#L226

I think it's not easy to fix them in a generic way.  To support different 

SQL compatibility modes well, many place of current codebase is possible to be modified.

It will `drill a hole` to pass the SqlConformance config in the whole process of  one sql query.

May be we can put the SqlConformance config in ThreadLocal, avoiding pass it frequently.