Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-2807

Identify expanded IS NOT DISTINCT FROM expression when pushing down filter past join

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.20.0
    • Component/s: core

      Description

      IS NOT DISTINCT FROM expressions in join condition might actually be considered as equi-join conditions, and RelOptUtil#splitJoinConditions() has support for it. But some other join related functions/rules don't.

      One of them is RelOptUtil#pushDownJoinConditions (used by JoinPushExpressionsRule) which tries to push filter expressions below the join, but ends up modifying the join expression in a way which makes identify an IDNF condition impossible later.

      For example expression OR(AND(IS_NULL($1), IS_NULL($4)), EQUALS($1,$4)) will be changed into OR(AND($3, $6), EQUALS($1, $5)) which makes it harder/impossible for RelOptUtil#splitJoinConditions() to identify an IS NOT DISTINCT FROM equi-join condition.

      This is a variant of CALCITE-2803

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                laurent Laurent Goujon
                Reporter:
                laurent Laurent Goujon
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h