[CALCITE-2722] SqlImplementor createLeftCall method throws StackOverflowError

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.19.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Mykola Zerniuk
• Created: 03/Dec/18 09:44
• Updated: 25/Mar/19 00:10
• Resolved: 25/Feb/19 12:33

Description

SqlImplementor createLeftCall method is implemented using recursion. In this case if sql has a lot of AND or OR operators it throws StackOverflowError.

Caused by: java.lang.StackOverflowError
at org.apache.calcite.util.Util.skipLast(Util.java:1940)
at org.apache.calcite.util.Util.skipLast(Util.java:1935)
at org.apache.calcite.rel.rel2sql.SqlImplementor$Context.createLeftCall(SqlImplementor.java:763)
at org.apache.calcite.rel.rel2sql.SqlImplementor$Context.createLeftCall(SqlImplementor.java:765)
at org.apache.calcite.rel.rel2sql.SqlImplementor$Context.createLeftCall(SqlImplementor.java:765)

Since calcite converts IN list to OR this bug is also reproduces on huge IN list.

Issue Links

• links to: GitHub Pull Request #954
• links to: GitHub Pull Request #1048