Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-2690

Uses `getDigest ` instead of `toString` when gets RelNode's digest

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: core
    • Labels:
      None

      Description

      Currently, We use a lot of RelNode's toString method to get digest in Calcite project. However the semantics of toString method is ambiguity.  If some developers do not know the toString value of a RelNode will be used as digest and override toString method arbitrarily, the optimization result will be unexpected. So I suggest that we should use getDigest instead of toString to get RelNode's digest.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                godfreyhe godfrey he
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: