Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-2587

Avatica - Regenerate protobuf files for 3.6.1

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: avatica-1.13.0
    • Component/s: avatica
    • Labels:
      None

      Description

      I was looking into deprecation warnings and found that protobuf 3.6.0 should have added suppresswarnings to a few valueOf calls that were deprecated. However, the java files were not being regenerated even with the protobuf-maven-plugin.

      It seems like the checkStaleness flag was preventing the compilation even after updating protobuf from 3.5.x to 3.6.1.

      It doesn't look like there is a good reason to have checkStaleness set to true since the protobuf compilation is pretty quick. This should help us catch protobuf errors sooner.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                krisden Kevin Risden
                Reporter:
                krisden Kevin Risden
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: