[CALCITE-2503] AvaticaCommonsHttpClientImpl client needs to set user-token on HttpClientContext before sending the request

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: avatica-1.13.0
• Assignee: Karan Mehta
• Reporter: Karan Mehta
• Created: 29/Aug/18 17:40
• Updated: 03/Dec/18 00:27
• Resolved: 07/Sep/18 23:37

Description

One of the Avatica client implementations, AvaticaCommonsHttpClientImpl, uses a PoolingHttpClientConnectionManager. When using mutual authentication on the client pool, we need to ensure that we are setting a user-token on the HttpClientContext, otherwise it ends up creating a new connection everytime and not reusing it. See:  https://hc.apache.org/httpcomponents-client-ga/tutorial/html/advanced.html for more details

This results in significant perf degradation since every new connection tries to complete a SSL handshake (which is expensive)

See: https://stackoverflow.com/questions/548029/how-much-overhead-does-ssl-impose

Issue Links

• links to: GitHub Pull Request #67