Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-2463

Silence ERROR logs from CalciteException, SqlValidatorException

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.17.0
    • 1.19.0
    • core
    • None

    Description

      CalciteException and SqlValidatorException log exceptions at ERROR level.
      This is not appropriate since
      1) the exception might be expected by the caller
      2) exception might contain sensitive information
      3) ERROR level is not appropriate, since error in validation does not imply business-level error.

      I suggest to remove `LOGGER.error` calls from Calcite code.

      Logging exceptions at TRACE level is fine from my point of view, so client can enable trace logging if required for debug purposes.

      Attachments

        Issue Links

          Activity

            People

              julianhyde Julian Hyde
              vladimirsitnikov Vladimir Sitnikov
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: