[CALCITE-2438] RexCall#isAlwaysTrue return incorrect result

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.17.0
• Fix Version/s: 1.18.0
• Component/s: core
• Assignee: Zoltan Haindrich
• Reporter: pengzhiwei
• Created: 02/Aug/18 11:42
• Updated: 23/Dec/18 00:12
• Resolved: 06/Oct/18 10:42

Description

In the expression as followed:

((sal IS NULL) IS NOT NULL) IS FALSE

The RexCall#isAlwaysTrue return true,however the correct answer is false.

I find the reason is that there is a wrong logic in the  isAlwaysTrue,when getKind() is IS_NOT_FALSE、IS_FALSE and IS_NOT_FALSE :

Can you have a check for me,thanks!

Issue Links

• is duplicated by: CALCITE-2644 isAlwaysTrue broken for IS FALSE
• is related to: CALCITE-2257 Combination of predicates can be proved to be always true