[CALCITE-2107] Timezone not passed as part of granularity when passing TimeExtractionFunction to Druid

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.16.0
• Component/s: druid
• Assignee: Nishant Bangarwa
• Reporter: Nishant Bangarwa
• Created: 22/Dec/17 18:27
• Updated: 17/Mar/18 17:43
• Resolved: 18/Jan/18 01:40

Description

When sending granularity to TimeFormatExtractionFunction we need to add timezone to the granularity to align it with the timezone specified in calcite connection. If no timezone is specified in granularity, It is considered as UTC timezone by druid.
Note the return value in is as per granularity UTC and not IST as expected -

 @Test
  public void testTmeWithFilterOnFloorOnTimeWithTimezoneConversion() {
    final String sql = "Select cast(floor(\"timestamp\" to MONTH) as timestamp) as t from "
        + "\"foodmart\" where floor(\"timestamp\" to MONTH) >= '1997-04-30 18:30:00 UTC' order by t"
        + " limit 1";
    final String druidQueryPart1 = "filter\":{\"type\":\"bound\",\"dimension\":\"__time\","
        + "\"lower\":\"1997-05-01T00:00:00.000Z\",\"lowerStrict\":false,"
        + "\"ordering\":\"lexicographic\",\"extractionFn\":{\"type\":\"timeFormat\","
        + "\"format\":\"yyyy-MM-dd";
    final String druidQueryPart2 = "\"granularity\":\"month\",\"timeZone\":\"IST\","
        + "\"locale\":\"en-US\"}},\"dimensions\":[],\"metrics\":[],\"granularity\":\"all\"";

    CalciteAssert.that()
        .enable(enabled())
        .with(ImmutableMap.of("model", FOODMART.getPath()))
        .with(CalciteConnectionProperty.TIME_ZONE.camelName(), "IST")
        .query(sql)
        .runs()
        .queryContains(druidChecker(druidQueryPart1, druidQueryPart2))
        .returnsOrdered("T=1997-05-01 05:30:00");
  }

Issue Links

• is related to: CALCITE-1947 Add time/timestamp with local time zone types to optimizer
• relates to: CALCITE-2138 Add Locale.getDefault() to forbidden api list