[CALCITE-2055] Check year, month, day, hour, minute and second ranges for date and time literals

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.15.0
• Assignee: Julian Hyde
• Reporter: Vova Vysotskyi
• Created: 15/Nov/17 14:20
• Updated: 27/Sep/19 20:54
• Resolved: 21/Nov/17 03:12

Description

Currently, if the year that is passed into DateString constructor has five digits, the first digit is trimmed. This trimming happens in the DateTimeStringUtils.int4() method:

  private static void int4(StringBuilder buf, int i) {
    buf.append((char) ('0' + (i / 1000) % 10));
    buf.append((char) ('0' + (i / 100) % 10));
    buf.append((char) ('0' + (i / 10) % 10));
    buf.append((char) ('0' + i % 10));
  }

The same problem with month and day values.

Instead of trimming the value, the correct behaviour is to throw an exception if any of the values are outside the expected range.

Issue Links

• is related to: DRILL-5377 Five-digit year dates are displayed incorrectly via jdbc