For example, RexSimplify incorrectly simplifies 1 < x AND x < 3 to x < 3. Patch in linked PR.
Resolved in release 1.15.0 (2017-12-11).
Got it, thanks for the tips.
Thanks, Gian Merlino.
For commit messages, we tend to omit the trailing ".". If the commit fixes a bug, use the bug description, "RexSimplify incorrectly simplifies AND bounds" rather than what was done, "Fix RexSimplify behavior when literals come first." And add "Close apache/calcite#547" to the commit comments to trigger the ASF bot to close the PR.
Fixed in https://git1-us-west.apache.org/repos/asf?p=calcite.git;a=commit;h=06c18ca74df2d4bf20a5dccef11d424ab28c97d7.
Thanks for the review Julian. I'll make those changes and then commit the patch.
The process is loose. As a committer, you can commit directly, or you can ask for review. Your choice, and we won't blame you if you screw up.
FWIW, here's my review:
Julian Hyde last time I raised a PR you asked me if I could commit it directly. I haven't done that before, so I'm wondering, what is the process? Is it important to get someone else to review the code first or is it OK to commit unilaterally and then just update the JIRA?
Sorry if this is answered in a doc that I didn't see. Thanks!