Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.13.0
    • Component/s: druid
    • Labels:
      None

      Description

      Upgrade Druid to 0.9.2. Since we speak REST to Druid there are no maven dependencies to update, but we do need to make calcite-test-dataset work reliably with a 0.9.2 instance and there are a couple of places in the doc/site IIRC.

        Issue Links

          Activity

          Hide
          julianhyde Julian Hyde added a comment -

          Nishant Bangarwa, slim bouguerra, What versions of Druid do you think we should officially support in Calcite? Just 0.9.2, or multiple versions (say 0.9.1 and 0.10.x)? If so, how will we certify on multiple versions?

          Show
          julianhyde Julian Hyde added a comment - Nishant Bangarwa , slim bouguerra , What versions of Druid do you think we should officially support in Calcite? Just 0.9.2, or multiple versions (say 0.9.1 and 0.10.x)? If so, how will we certify on multiple versions?
          Hide
          julianhyde Julian Hyde added a comment -

          Have you successfully run Calcite's DruidAdapterIT against this VM? I get errors when I run master branch against it, and it is very slow (hasn't finished yet) when I run the PR for CALCITE-1734.

          Show
          julianhyde Julian Hyde added a comment - Have you successfully run Calcite's DruidAdapterIT against this VM? I get errors when I run master branch against it, and it is very slow (hasn't finished yet) when I run the PR for CALCITE-1734 .
          Hide
          julianhyde Julian Hyde added a comment -

          OK, the test runs successfully with CALCITE-1734. It is slow (DruidAdapterIT#testFilterTimestamp alone took 4m) but it finishes. I was faster if I increased the VM's memory from 3G to 6G (see https://github.com/julianhyde/calcite-test-dataset/commit/c07da47cfbf724f7c9e3e0b997cc87ced8949831) but I think we should keep the base VM at 3G.

          Two changes, please:

          • Update Calcite's doc (history.md and druid_adapter.md), stating which version(s) are supported
          • In install.sh, convert zookeeper version into a variable as you did for druid version

          When you make those changes I'll +1 your https://github.com/vlsi/calcite-test-dataset/pull/19 and will also rebase https://github.com/vlsi/calcite-test-dataset/pull/18 and start testing that.

          Show
          julianhyde Julian Hyde added a comment - OK, the test runs successfully with CALCITE-1734 . It is slow ( DruidAdapterIT#testFilterTimestamp alone took 4m) but it finishes. I was faster if I increased the VM's memory from 3G to 6G (see https://github.com/julianhyde/calcite-test-dataset/commit/c07da47cfbf724f7c9e3e0b997cc87ced8949831 ) but I think we should keep the base VM at 3G. Two changes, please: Update Calcite's doc (history.md and druid_adapter.md), stating which version(s) are supported In install.sh , convert zookeeper version into a variable as you did for druid version When you make those changes I'll +1 your https://github.com/vlsi/calcite-test-dataset/pull/19 and will also rebase https://github.com/vlsi/calcite-test-dataset/pull/18 and start testing that.
          Hide
          nishantbangarwa Nishant Bangarwa added a comment -

          I believe we would need to support both 0.10 and 0.9.
          Julian Hyde curious how do we test multiple versions for other projects ? e.g guava ?

          Also, I have made above requested changes to test vm for zk versioning and calcite docs.

          Show
          nishantbangarwa Nishant Bangarwa added a comment - I believe we would need to support both 0.10 and 0.9. Julian Hyde curious how do we test multiple versions for other projects ? e.g guava ? Also, I have made above requested changes to test vm for zk versioning and calcite docs.
          Hide
          julianhyde Julian Hyde added a comment -

          It's easy to test multiple guava versions e.g. mvn clean install -Dguava.version=14.0.1 builds and runs the suite with Guava 14.0.1. Similarly, testing with multiple JDK versions can be scripted.

          But testing multiple Druid versions would require tearing down & rebuilding the VM between runs. And the Vagrant script is not even parameterized currently.

          I am inclined to just have one supported version of Druid, unless we get some more resources for testing. If people certify an RC on other Druid versions we can add that to the release notes, but it would not be an exit criterion for the release.

          Show
          julianhyde Julian Hyde added a comment - It's easy to test multiple guava versions e.g. mvn clean install -Dguava.version=14.0.1 builds and runs the suite with Guava 14.0.1. Similarly, testing with multiple JDK versions can be scripted. But testing multiple Druid versions would require tearing down & rebuilding the VM between runs. And the Vagrant script is not even parameterized currently. I am inclined to just have one supported version of Druid, unless we get some more resources for testing. If people certify an RC on other Druid versions we can add that to the release notes, but it would not be an exit criterion for the release.
          Hide
          nishantbangarwa Nishant Bangarwa added a comment -

          Julian Hyde sounds good.

          Show
          nishantbangarwa Nishant Bangarwa added a comment - Julian Hyde sounds good.
          Show
          jcamachorodriguez Jesus Camacho Rodriguez added a comment - Pushed PR to update to 0.9.2 in https://github.com/vlsi/calcite-test-dataset/commit/f5de94f and updated documentation in http://git-wip-us.apache.org/repos/asf/calcite/commit/bff34c1 . Thanks Nishant Bangarwa !
          Hide
          jcamachorodriguez Jesus Camacho Rodriguez added a comment -

          Resolved in release 1.13.0 (2017-06-26).

          Show
          jcamachorodriguez Jesus Camacho Rodriguez added a comment - Resolved in release 1.13.0 (2017-06-26).

            People

            • Assignee:
              nishantbangarwa Nishant Bangarwa
              Reporter:
              julianhyde Julian Hyde
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development