[CALCITE-1585] SqlPrettyWriter doesn't respect alwaysUseParentheses

• Type: Bug
• Status: Open
• Priority: Trivial
• Resolution: Unresolved
• Affects Version/s: 1.11.0
• Component/s: core
• Assignee: Unassigned
• Reporter: Jess Balint
• Created: 18/Jan/17 02:55
• Updated: 22/Feb/19 01:19

Description

The SqlPrettyWriter constructor is as follows:

  public SqlPrettyWriter(
      SqlDialect dialect,
      boolean alwaysUseParentheses,
      PrintWriter pw) {
    if (pw == null) {
      pw = new PrintWriter(sw);
    }
    this.pw = pw;
    this.dialect = dialect;
    this.alwaysUseParentheses = alwaysUseParentheses;
    resetSettings();
    reset();
  }

The resetSettings() method overrides this.alwaysUseParentheses to FALSE.