Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.11.0
    • Component/s: None
    • Labels:
      None

      Description

      Improve RelNode validation by:

      • adding a context to the RelNode.isValid method;
      • enabling the Join.isValid method (it was previously renamed to isValid_, thus disabled).

      The context to isValid will allow the validator to deduce what correlation variables are available (namely, those set by a RelNode between this one and the root). The context is optional; if null, the isValid method does the best it can.

      RexInputRef s in the condition of a null-generating side of an outer join currently may be nullable when they should not be; the row type in the namespace is currently made nullable when actually only particular uses of the namespace should be nullable. We introduce class ScopeChild to hold the ordinal, row type and nullability of a use of a namespace.

        Activity

        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.11.0 (2017-01-11).

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.11.0 (2017-01-11).
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/70b83251 .
        Hide
        julianhyde Julian Hyde added a comment -

        A partial fix (adding Context parameter to isValid) is in http://git-wip-us.apache.org/repos/asf/calcite/commit/3f261072. More to come.

        Show
        julianhyde Julian Hyde added a comment - A partial fix (adding Context parameter to isValid ) is in http://git-wip-us.apache.org/repos/asf/calcite/commit/3f261072 . More to come.

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            julianhyde Julian Hyde
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development