Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1367

Implement equals and hashCode for all sub-classes of RexNode

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: 1.18.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently not all sub-classes of RexNode override Object.equals and Object.hashCode methods, so they can't be used in java collections, e.g. as keys in maps.

      To fix, override equals and hashCode in RexCall and maybe other sub-classes. See if there are workarounds (using digests instead of the RexNode themselves, using IdentityHashMap, using canonization) and if appropriate remove them.

        Attachments

          Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. CALCITE-2632 Add hashCode and equals implementations to RexNode

          • Major - Major loss of function.
          • Closed

            Activity

              People

              • Assignee:
                julianhyde Julian Hyde
                Reporter:
                julianhyde Julian Hyde
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: