Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1290

When converting to CNF, fail if the expression size exceeds a threshold

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.9.0
    • None
    • None

    Description

      When converting to conjunctive normal form (CNF), fail if the expression exceeds a threshold. CNF can explode exponentially in the size of the input expression, but rarely does so in practice. Add a maxNodeCount parameter to RexUtil.toCnf and throw or return null if it is exceeded.

      I don't believe it is possible to predict the size of the CNF from the input expression (especially if there are duplicate terms) but I might be wrong.

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. CALCITE-1356 Release Calcite 1.9.0

          • Major - Major loss of function.
          • Closed
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. HIVE-14021 When converting to CNF, fail if the expression exceeds a threshold

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. CALCITE-5365 RelMdExpressionLineage#createAllPossibleExpressions will create many RexCall lead to OOM

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. CALCITE-1790 Simplify CASE P1 THEN <boolean> P@ THEN <booleans> ... ELSE TRUE/FALSE

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            People

              jcamacho Jesús Camacho Rodríguez
              julianhyde Julian Hyde
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: